Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sps-Idempotency-Key Header Proposal #98

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Sps-Idempotency-Key Header Proposal #98

wants to merge 5 commits into from

Conversation

nicholas-s-perkins
Copy link
Contributor

@nicholas-s-perkins nicholas-s-perkins commented Dec 12, 2024 •
edited by travisgosselin
Loading

@nicholas-s-perkins nicholas-s-perkins requested a review from a team as a code owner December 12, 2024 00:22
travisgosselin
travisgosselin reviewed Dec 12, 2024
View reviewed changes
standards/request-response.md Outdated Show resolved Hide resolved
standards/request-response.md Outdated Show resolved Hide resolved
standards/request-response.md Outdated Show resolved Hide resolved
standards/request-response.md Outdated Show resolved Hide resolved
standards/request-response.md Outdated Show resolved Hide resolved
standards/request-response.md Outdated Show resolved Hide resolved
standards/request-response.md Outdated Show resolved Hide resolved
nicholas-s-perkins and others added 2 commits December 12, 2024 10:53
@nicholas-s-perkins @travisgosselin
Update standards/request-response.md
8d721e1 
Co-authored-by: Travis Gosselin <[email protected]>
Signed-off-by: Nicholas Perkins <[email protected]>
@nicholas-s-perkins
Updated some notes
0b7a62b
@travisgosselin travisgosselin changed the title Idempotency-Key Header Proposal Sps-Idempotency-Key Header Proposal Dec 19, 2024
@travisgosselin travisgosselin added the minor-change Small non-breaking modification to existing API Standard details. label Jan 3, 2025
@travisgosselin
Copy link
Member

@nicholas-s-perkins please review, I made all minor changes, formatting, ordering, and added a some bullets / minor content. Please indicate if you have any further changes on your side?

nicholas-s-perkins
nicholas-s-perkins commented Jan 8, 2025
View reviewed changes
Copy link
Contributor Author

@nicholas-s-perkins nicholas-s-perkins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes. I don't think I have anything else to add.

acchristensen
acchristensen approved these changes Jan 9, 2025
View reviewed changes
Copy link

@acchristensen acchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and concise. I appreciate the examples. I think we've hashed out other options and landing here seems right. lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisgosselin travisgosselin travisgosselin left review comments

@acchristensen acchristensen acchristensen approved these changes

@mkokotovich mkokotovich Awaiting requested review from mkokotovich

Assignees

@nicholas-s-perkins nicholas-s-perkins

Labels
minor-change Small non-breaking modification to existing API Standard details.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-s-perkins @travisgosselin @acchristensen